Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Compatibility with ActiveSupport 3.0

#120

The loading order of modules at adhearsion.rb is wrong.

The Active Support load last, while some of it requirements are needed prior to it's loading.

By Moving require 'active_support/core_ext' it will solve the error message of:
$ ahn /opt/ruby1.8/lib/ruby/gems/1.8/gems/adhearsion-0.8.6/lib/adhearsion/component_manager.rb:4: undefined method mattr_accessor' for Adhearsion::Components:Module (NoMethodError)

    from /opt/ruby1.8/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
    from /opt/ruby1.8/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
    from /opt/ruby1.8/lib/ruby/gems/1.8/gems/adhearsion-0.8.6/lib/adhearsion.rb:17
    from /opt/ruby1.8/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
    from /opt/ruby1.8/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
    from ./ahn:25

Reported by ik_5 · October 10th, 2010 @ 07:19 AM

State: resolved
Milestone: 1.0.0
Assigned to: Ben Klang Ben Klang

Activity

  1. Ben Klang
    Ben Klang
    • State changed from new to open
    • Milestone set to 1.0.0
    • Assigned user set to Ben Klang
    • Milestone order changed from 3033 to 0

    I've noticed this too. Based on my testing that require will work with ActiveSupport 2.3 as well as 3.0, so it should be safe to change. I'll do some additional testing and verify before committing.

    October 18th, 2010 @ 09:06 PM

  2. Ben Klang
    Ben Klang
    • Tag set to activesupport, dependencies

    October 18th, 2010 @ 09:07 PM

  3. Ben Klang
    Ben Klang
    • Title changed from mattr_accessor not found to Compatibility with ActiveSupport 3.0

    October 21st, 2010 @ 06:56 PM

  4. Ben Klang
    Ben Klang
    • State changed from open to fixcommitted

    With the latest round of commits I believe this issue is resolved. Adhearsion users will be forced to have AS2.3 and AS3.0 installed at the same time because of a dependency in Rubigen. However at runtime the AS2.3 will not be loaded.

    See http://github.com/adhearsion/adhearsion/commit/5f9a9d41d5afde169d68...

    October 26th, 2010 @ 12:18 PM

  5. Ben Klang
    Ben Klang
    • State changed from fixcommitted to resolved

    October 28th, 2010 @ 10:43 AM

  6. eggie5 (at gmail)
    eggie5 (at gmail)

    Still seeing this error:

    rubygems.rb:238:in activate': can't activate activesupport (~> 2.3.5, runtime) for ["rubigen-1.5.5"], already activated activesupport-3.0.3 for ["adhearsion-1.0.0"] (Gem::LoadError)

    I have both activesupport libs: activesupport (3.0.3, 3.0.1, 3.0.0, 3.0.0.beta4, 2.3.10)
    running ruby 1.9
    adhearsion v 1.0

    January 7th, 2011 @ 08:34 PM

  7. Ben Klang
    Ben Klang

    I have received commit rights from Dr. Nic and made a commit to the RubiGen project that should fix this issue once and for all.

    Testing and feedback welcome: https://github.com/drnic/rubigen/commit/70f836ecfd4299a29cfc6446963...

    Hopefully this will result in a quick release of RubiGen 1.5.6 and Adhearsion 1.0.1.

    January 11th, 2011 @ 12:15 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.