Compatibility with ActiveSupport 3.0
Reported by ik_5 | 2010-10-10 07:19:51 UTC | in 1.0.0
The loading order of modules at adhearsion.rb is wrong.
The Active Support load last, while some of it requirements are needed prior to it's loading.
By Moving require 'active_support/core_ext' it will solve the
error message of:
$ ahn
/opt/ruby1.8/lib/ruby/gems/1.8/gems/adhearsion-0.8.6/lib/adhearsion/component_manager.rb:4:
undefined method mattr_accessor' for
Adhearsion::Components:Module (NoMethodError)
from /opt/ruby1.8/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
from /opt/ruby1.8/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
from /opt/ruby1.8/lib/ruby/gems/1.8/gems/adhearsion-0.8.6/lib/adhearsion.rb:17
from /opt/ruby1.8/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
from /opt/ruby1.8/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
from ./ahn:25
Comments and changes to this ticket
-
Ben Klang 2010-10-18 21:06:37 UTC
- State changed from “new” to “open”
- Milestone set to “1.0.0”
- Assigned user set to “Ben Klang”
- Milestone order changed from “3033” to “0”
I've noticed this too. Based on my testing that require will work with ActiveSupport 2.3 as well as 3.0, so it should be safe to change. I'll do some additional testing and verify before committing.
-
Ben Klang 2010-10-18 21:07:00 UTC
- Tag set to “activesupport, dependencies”
-
Ben Klang 2010-10-21 18:56:37 UTC
- Title changed from “mattr_accessor not found” to “Compatibility with ActiveSupport 3.0”
-
Ben Klang 2010-10-26 12:18:29 UTC
- State changed from “open” to “fixcommitted”
With the latest round of commits I believe this issue is resolved. Adhearsion users will be forced to have AS2.3 and AS3.0 installed at the same time because of a dependency in Rubigen. However at runtime the AS2.3 will not be loaded.
See http://github.com/adhearsion/adhearsion/commit/5f9a9d41d5afde169d68...
-
Ben Klang 2010-10-28 10:43:42 UTC
- State changed from “fixcommitted” to “resolved”
-
eggie5 (at gmail) 2011-01-07 20:34:57 UTC
Still seeing this error:
rubygems.rb:238:in
activate': can't activate activesupport (~> 2.3.5, runtime) for ["rubigen-1.5.5"], already activated activesupport-3.0.3 for ["adhearsion-1.0.0"] (Gem::LoadError)I have both activesupport libs: activesupport (3.0.3, 3.0.1, 3.0.0, 3.0.0.beta4, 2.3.10)
running ruby 1.9
adhearsion v 1.0 -
Ben Klang 2011-01-11 12:15:32 UTC
I have received commit rights from Dr. Nic and made a commit to the RubiGen project that should fix this issue once and for all.
Testing and feedback welcome: https://github.com/drnic/rubigen/commit/70f836ecfd4299a29cfc6446963...
Hopefully this will result in a quick release of RubiGen 1.5.6 and Adhearsion 1.0.1.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Ben Klang
ik_5