Ruby 1.9 warns against undefining object_id
Reported by Ben Klang | October 28th, 2010 @ 09:09 AM | in 1.0.1
/usr/lib/ruby/gems/1.9.2/gems/adhearsion-0.8.7/lib/adhearsion/
foundation/blank_slate.rb:2: warning: undefining object_id'
may cause<br/> serious problems<br/>
/usr/lib/ruby/gems/1.9.2/gems/adhearsion-0.8.7/lib/theatre/
callback\_definition\_loader.rb:64: warning:
undefiningobject_id' may
cause serious problems
/usr/lib/ruby/gems/1.9.2/gems/adhearsion-0.8.7/lib/adhearsion/voip/dsl/
numerical_string.rb:22: warning: undefining object_id' may
cause<br/> serious problems<br/>
/usr/lib/ruby/gems/1.9.2/gems/adhearsion-0.8.7/lib/adhearsion/voip/dsl/
dialplan/parser.rb:49: warning: undefiningobject_id' may
cause
serious problems
In Ruby 1.8 the method Module#instance_methods returns an array of strings. In Ruby 1.9 it returns an array of symbols. This breaks our code when we protect certain methods in BlankSlate (and 3 other places).
I want to look at replacing our BlankSlate module with the
blankslate gem. Also I want to clean up the 4 places we repeat
ourselves with this logic.
lib/adhearsion/foundation/blank_slate.rb
lib/adhearsion/voip/dsl/dialplan/parser.rb
lib/adhearsion/voip/dsl/numerical_string.rb
lib/theatre/callback_definition_loader.rb
Comments and changes to this ticket
-
Ben Klang October 28th, 2010 @ 10:43 AM
- Milestone set to “1.0.1”
- Milestone order changed from “3034” to “0”
-
eggie5 (at gmail) January 7th, 2011 @ 08:21 PM
I see this in ruby 1.9 too. So are you saying the code is broke on ruby 1.9??? Should I not use 1.9 w/ adhearsion?
-
Ben Klang January 11th, 2011 @ 12:19 PM
Please see the ruby19 branch on Github: https://github.com/adhearsion/adhearsion/tree/ruby19
Ruby 1.9 support is a near-term goal for Adhearsion.
-
Ben Klang January 26th, 2011 @ 03:27 PM
- State changed from “open” to “fixcommitted”
-
Ben Klang March 4th, 2011 @ 11:07 AM
- State changed from “fixcommitted” to “resolved”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Ben Klang
eggie5 (at gmail)