Menu method under JRuby does not appear to work

Hi,

The problem exists with jump_to command which is used by menu.
I did some investigation and see in commands.rb in def jump_to there is following:

raise Adhearsion::VoIP::DSL::Dialplan::ContextNotFoundException unless context.kind_of?(Adhearsion::DialPlan::DialplanContextProc)

I check under jruby and see that context.class == 'Proc', but not 'Adhearsion::DialPlan::DialplanContextProc'
So, as a temporary hack we can use the following:

raise Adhearsion::VoIP::DSL::Dialplan::ContextNotFoundException unless context.kind_of?(Proc)

instead of above.

I have traced this down to what I believe is a bug in JRuby. As dilshodm observed, the class is incorrectly being reported as a Proc, instead of Adhearsion::Dialplan::DialplanContextProc. I did a couple of quick tests in JRuby:

module Adhearsion
  class Foo

    def self.new_bar(&block)
      Bar.new(&block)
    end

    class Bar < Proc
      def initialize(&block)
        super(&block)
      end
    end
  end
end

With the above code I tried two different ways of getting a Adhearsion::Foo::Bar object:

x = Adhearsion::Foo::Bar.new { puts "x" }
puts x.class # => Adhearsion::Foo::Bar

x = Adhearsion::Foo.new_bar { puts "x" }
puts x.class # => Proc

I will file a bug with the JRuby developers. In the meantime I will find a safe workaround to re-enable the menu DSL under JRuby.

Issue reported to JRuby here:
http://jira.codehaus.org/browse/JRUBY-5026

A workaround has been committed. This effectively addresses the issue.

http://github.com/adhearsion/adhearsion/commit/98fd9530a9a7cd9ef236...

The problem is that JRuby is actually not instantiating the class correctly. Because of this the workaround I committed only fixes part of the problem. Using the +context syntax to include another context will still not work in JRuby.

JRuby has fixed the issue and it will appear in 1.6.0. Until then Menu will only have limited functionality under JRuby. This needs to be documented.

Charles Nutter has noted in the JRuby bug report that the DialPlanProc class will not properly get initialized. The workaround I committed will make most of the menu work, but I do not consider adding more workarounds for this bug in JRuby to be feasible. A check has been added to the top of dial_plan.rb that will warn users who have an affected version of JRuby. The bugfix in JRuby is currently scheduled to be a part of the 1.6.0 release.

Based on my testing, the basic menu functionality will work. The only thing I see that will not work is the "+context" functionality to jump from one context to another.

my_context {
  +other_context
}

other_context {
  play "demo-congrats
}

A call into "my_context" will result in this type of exception:

ERROR agi: NoMethodError: undefined method `+@' for #<Proc:0x734d246@/Users/bklang/src/ahn_app/dialplan.rb:33>